Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Tooling: Move wp-polyfill-ecmascript override to scripts registration #11696

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Build Tooling: Move wp-polyfill-ecmascript override to scripts registration #11696

merged 1 commit into from
Nov 9, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 9, 2018 •
edited
Loading

Related: #11216

This pull request seeks to resolve an issue where the plugin packaging procedure fails. The vendor file download process calls gutenberg_register_vendor_scripts with a very small subset of stubbed PHP functions, which does not include gutenberg_override_script. The function call should not occur here anyways, as it is not strictly relevant to the registration of vendor scripts. Thus, with these changes it has been moved into gutenberg_register_scripts_and_styles.

Testing instructions:

Repeat testing instructions from #11216

Verify the plugin packaging completes without errors:

npm run package-plugin

@aduth aduth added the [Type] Build Tooling Issues or PRs related to build tooling label Nov 9, 2018
@aduth aduth mentioned this pull request Nov 9, 2018
Merged
tofumatt
tofumatt approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build worked for me now and the built plugin worked. I'm gonna merge this so I can build another RC for 4.3. 👍

@earnjam
Copy link
Contributor

earnjam commented Nov 9, 2018

Already got an approval, but I'll add a ditto on both counts 😄

@tofumatt tofumatt merged commit 77bd99b into master Nov 9, 2018
@tofumatt tofumatt deleted the fix/plugin-build-override-polyfill branch November 9, 2018 20:19
youknowriad pushed a commit that referenced this pull request Nov 12, 2018
@aduth @tofumatt
Framework: Move wp-polyfill-ecmascript override to scripts registrati…
27bade3 
…on (#11696)
@swissspidy swissspidy mentioned this pull request Dec 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@earnjam earnjam earnjam approved these changes

Assignees
No one assigned
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @earnjam @tofumatt